Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash dismissing bottom-sheet on iOS after device rotation #1628

Merged
merged 4 commits into from
Nov 28, 2019
Merged

Fix crash dismissing bottom-sheet on iOS after device rotation #1628

merged 4 commits into from
Nov 28, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Nov 27, 2019 •
edited
Loading

Fixes #1522

This PR updates the gutenberg ref to test WordPress/gutenberg#18782

gutenberg side PR: WordPress/gutenberg#18782

To test:

  • Load the example content.
  • Find the Image block with image.
  • Press the image settings button.
  • Rotate the device.
  • Dismiss the settings sheet by pressing outside of it.
  • Check that it does not crash.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added this to the 1.19 milestone Nov 27, 2019
@etoledom etoledom self-assigned this Nov 27, 2019
@etoledom etoledom mentioned this pull request Nov 27, 2019
Merged
@etoledom etoledom marked this pull request as ready for review November 27, 2019 14:06
SergioEstevao
SergioEstevao approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS (phone and tablet) and Android and it's all working great!

:shipit:

@etoledom etoledom merged commit 509bf96 into develop Nov 28, 2019
@etoledom etoledom deleted the issue/1522-fix-crash-rotating-bottom-sheet-ios branch November 28, 2019 08:34
@cameronvoell cameronvoell mentioned this pull request Dec 13, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees

@etoledom etoledom

Labels
bugfix
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.

Crash on rotation with BottomSheet on iOS
2 participants
@etoledom @SergioEstevao