Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on rotation with BottomSheet on iOS #1522

Closed
etoledom opened this issue Oct 31, 2019 · 0 comments · Fixed by WordPress/gutenberg#18782 or #1628
Closed

Crash on rotation with BottomSheet on iOS #1522

etoledom opened this issue Oct 31, 2019 · 0 comments · Fixed by WordPress/gutenberg#18782 or #1628

Comments

@etoledom
Copy link
Contributor

crash

Steps:

  • Open a new post.
  • Add a paragraph block.
  • Press the link toolbar button.
  • Rotate the device.
  • Dismiss the settings sheet by pressing outside of it.
    -💥

Testing on sample app:

  • Load the example content.
  • Find the Image block with image.
  • Press the image settings button.
  • Rotate the device.
  • Dismiss the settings sheet by pressing outside of it.
    -💥

I noticed that this only happens the first time the bottom-sheet is opened.

Error:

TypeError: _this.contentRef[animationOut] is not a function

This error is located at:
    in ReactNativeModal (at bottom-sheet/index.native.js:127)
    in BottomSheet (at with-preferred-color-scheme/index.native.js:22)
    in WithPreferredColorScheme(BottomSheet) (at container.native.js:16)
    in BottomSheetSettings (at with-dispatch/index.js:98)
    in WithDispatch(BottomSheetSettings) (at with-select/index.js:60)
    in Unknown (at pure/index.js:38)
    in WithSelect(WithDispatch(BottomSheetSettings)) (at layout/index.native.js:132)
    in RCTView (at View.js:35)
    in View (at KeyboardAvoidingView.js:204)
    in KeyboardAvoidingView (at keyboard-avoiding-view/index.ios.js:11)
    in KeyboardAvoidingView (at layout/index.native.js:127)
    in RCTSafeAreaView (at SafeAreaView.js:54)
    in SafeAreaView (at layout/index.native.js:120)
    in Layout (at with-preferred-color-scheme/index.native.js:22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant