Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Slider from react-native-community lib #1620

Merged
merged 22 commits into from
Dec 5, 2019
Merged

Use Slider from react-native-community lib #1620

merged 22 commits into from
Dec 5, 2019

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Nov 26, 2019 •
edited
Loading

Fixes issue with jumping Slider on ios ~13
I added within gutenberg-mobile new library react-native-slider which is going to replace Slider from react-native which will be deprecated soon and what's more have a bug on ios ~13.

Ref to gutenberg: WordPress/gutenberg#18806
Ref to WordPress-Android:wordpress-mobile/WordPress-Android#10871
Ref to WordPress-iOS:wordpress-mobile/WordPress-iOS#13019

To test:

I was testing it in WordPress-Android, WordPress-iOS and also within a playground.

  1. Add Spacer block on mobile
  2. Play with Slider
  • I suggest you also to set small range eg. minValue=0, maxValue=20 in RangeCell to check if Slider is not jumping

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@lukewalczak lukewalczak force-pushed the feat/update-slider branch 3 times, most recently from 95c3ef1 to 81efe78 Compare November 27, 2019 11:49
@lukewalczak lukewalczak mentioned this pull request Nov 28, 2019
Merged
6 tasks
@lukewalczak lukewalczak self-assigned this Nov 28, 2019
@lukewalczak lukewalczak added [OS] Android dependencies Pull requests that update a dependency file [OS] iOS labels Nov 28, 2019
@lukewalczak lukewalczak marked this pull request as ready for review November 28, 2019 14:05
@lukewalczak lukewalczak mentioned this pull request Nov 28, 2019
Merged
2 tasks
@lukewalczak lukewalczak mentioned this pull request Nov 28, 2019
Merged
2 tasks
@pinarol pinarol requested review from marecar3 and etoledom November 28, 2019 15:59
@etoledom etoledom added this to the 1.19 milestone Dec 4, 2019
etoledom
etoledom approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on iOS

Tested on WPiOS and the example app 👍
Great job 🎉

marecar3
marecar3 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and it's working good!
LGTM!

@lukewalczak lukewalczak mentioned this pull request Dec 5, 2019
Closed
1 task
@lukewalczak lukewalczak merged commit e6ac571 into develop Dec 5, 2019
@lukewalczak lukewalczak deleted the feat/update-slider branch December 5, 2019 11:25
@cameronvoell cameronvoell mentioned this pull request Dec 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@etoledom etoledom etoledom approved these changes

Assignees

@lukewalczak lukewalczak

Labels
dependencies Pull requests that update a dependency file [OS] Android [OS] iOS
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@lukewalczak @etoledom @marecar3