-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Replace Slider #18806
[RNMobile] Replace Slider #18806
Conversation
Actually this is a pretty important test case since that jumpiness on iOS 13.x is the main reason we wanted to make this change. |
Could you also add the gif that demonstrates the odd behavior @lukewalczak ? It is not clear for reviewers what we are fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved iOS side via wordpress-mobile/gutenberg-mobile#1620 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Android and it's working good!
LGTM!
Description
I added within
gutenberg-mobile
new libraryreact-native-slider
which is going to replaceSlider
fromreact-native
which will be deprecated soon and what's more have a bug on ios ~13.Ref to gb-mobile:wordpress-mobile/gutenberg-mobile#1620
Ref to WordPress-Android:wordpress-mobile/WordPress-Android#10871
Ref to WordPress-iOS:wordpress-mobile/WordPress-iOS#13019
How has this been tested?
I was testing it in WordPress-Android, WordPress-iOS and also within a playground.
Spacer
block on mobileSlider
Screenshots
Types of changes
Checklist: