Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement video block settings #1601

Merged
merged 8 commits into from
Nov 28, 2019
Merged

Implement video block settings #1601

merged 8 commits into from
Nov 28, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 21, 2019 •
edited
Loading

Added the missing Inspector Controls for video, except for the setting of the poster image that needs more custom work for native.

Simulator Screen Shot - iPhone 11 Pro Max - 2019-11-21 at 10 27 20

Gutenberg PR: WordPress/gutenberg#18660

To test:

  • Open the demo app
  • Tap on a video block
  • Tap on the settings icon (cog)
  • Check that the settings change the generated HTML

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added [Type] Enhancement Improves a current area of the editor Blocks labels Nov 21, 2019
@SergioEstevao SergioEstevao added this to the 1.18 milestone Nov 21, 2019
@SergioEstevao SergioEstevao changed the title Issue/implement video properties Implement video block settings Nov 21, 2019
@SergioEstevao SergioEstevao mentioned this pull request Nov 21, 2019
Merged
6 tasks
@marecar3
Copy link
Contributor

Hey @SergioEstevao, can we maybe link issue with this PR? Thanks.

marecar3
marecar3 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioEstevao SergioEstevao merged commit d39c152 into develop Nov 28, 2019
@SergioEstevao SergioEstevao deleted the issue/implement_video_properties branch November 28, 2019 10:50
@cameronvoell cameronvoell modified the milestones: 1.18, 1.19 Dec 13, 2019
This was referenced Dec 13, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@pinarol pinarol Awaiting requested review from pinarol

Assignees
No one assigned
Labels
Blocks [Type] Enhancement Improves a current area of the editor
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @marecar3 @cameronvoell