Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement video settings. #18660

Merged
merged 6 commits into from
Nov 28, 2019
Merged

Implement video settings. #18660

merged 6 commits into from
Nov 28, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 21, 2019 •
edited
Loading

Description

Added the missing Inspector Controls for video, except for the setting of the poster image that needs more custom work for native.

How has this been tested?

This can be tested using this GB mobile PR.

Screenshots

Simulator Screen Shot - iPhone 11 Pro Max - 2019-11-21 at 10 27 20

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@SergioEstevao SergioEstevao added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 21, 2019
@SergioEstevao SergioEstevao mentioned this pull request Nov 21, 2019
Merged
1 task
marecar3
marecar3 approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Working good.

@SergioEstevao I didn't expect that click on the cell can toggle the switch on/off.
Can we somehow disable the click and just toggle the switch when the switch component is clicked

@SergioEstevao
Copy link
Contributor Author

Can we somehow disable the click and just toggle the switch when the switch component is clicked

This is the way the toggle control is currently implemented, it's the same behaviour in link settings. I imagine this is expected behaviour for the setting.

@marecar3
Copy link
Contributor

marecar3 commented Nov 26, 2019 •
edited
Loading

Can we somehow disable the click and just toggle the switch when the switch component is clicked

This is the way the toggle control is currently implemented, it's the same behaviour in link settings. I imagine this is expected behaviour for the setting.

Thanks, @SergioEstevao let's merge it then 👍

@SergioEstevao SergioEstevao merged commit f50a976 into master Nov 28, 2019
@SergioEstevao SergioEstevao deleted the rnmobile/video_implement_block_settings branch November 28, 2019 10:14
@jorgefilipecosta jorgefilipecosta mentioned this pull request Dec 5, 2019
Merged
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@pinarol pinarol Awaiting requested review from pinarol

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioEstevao @marecar3 @youknowriad