Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master -> Develop (1.17.1) #1599

Closed
wants to merge 7 commits into from
Closed

Master -> Develop (1.17.1) #1599

wants to merge 7 commits into from

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Nov 20, 2019

This PR is to bring the changes from the master branch back into develop.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@Tug Tug self-assigned this Nov 20, 2019
@Tug Tug requested a review from hypest November 20, 2019 14:03
hypest
hypest approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Tug , but apparently it needs updating before merging. Can you update it? Thanks!

@Tug
Copy link
Contributor Author

Tug commented Nov 27, 2019

We can't update master though. I'll have to create a new branch master-merge-1.7.1

@Tug Tug mentioned this pull request Nov 27, 2019
Merged
1 task
@Tug
Copy link
Contributor Author

Tug commented Nov 27, 2019

Closing as it will be done in #1622

@Tug Tug closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@Tug Tug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tug @hypest