Automate gutenberg translations followup #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Tug
force-pushed
the
fix/i18n-plurals-android
branch
from
15a5d0b to
dc5344f
Compare
Tug
force-pushed
the
fix/i18n-plurals-android
branch
from
f799392 to
afbf2a9
Compare
hypest
reviewed
Nov 18, 2019
|
|
||
| const indent = ' '; | ||
|
|
||
| /** | ||
| * Encode a raw string into an Android-compatible value |
There was a problem hiding this comment.
Should we also encode quotes and double-quotes?
There was a problem hiding this comment.
Yep, JSON.stringify is going to take care of that
There was a problem hiding this comment.
Single quotes don't need to be encoded though as they'll be contained in a double quote string. See https://github.com/wordpress-mobile/gutenberg-mobile/pull/1589/files#diff-8a38584e71e09430592cd316ae4d6851R82
This was referenced Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve our i18n flow. There are 3 main improvements we need to take care of:
<string-array>tags for plurals instead of<plurals>Testing Instructions
yarn genstringsgit diff)Update release notes:
RELEASE-NOTES.txt.