Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile fullscreen image preview #1527

Closed
wants to merge 3 commits into from

Conversation

cameronvoell
Copy link
Contributor

Implements #1286
*This feature is behind a __DEV__ because of Android rotation issues.
For Android, see this work for in progress PR: wordpress-mobile/WordPress-Android#10714
(Android is disabled in this PR because of this: #1333)

Gutenberg PR: WordPress/gutenberg#17109

To test:

  1. Open article in the block editor.
  2. Navigate to an image block with an image loaded, or add a new image block and add an image
  3. Select the image block and notice the blue border shows around the image
  4. Press the image while the image block is selected and notice the image will be viewed in fullscreen.
  5. Press outside the boundaries of the image in fullscreen mode, or swipe the image down to exit the fullscreen image preview.

Update release notes: No, behind __DEV__

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@cameronvoell cameronvoell added [Status] Needs Design Review Needs design review or sign-off before shipping Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile labels Nov 1, 2019
@cameronvoell cameronvoell added the [Status] DO NOT MERGE Do not merge this PR label Nov 4, 2019
@cameronvoell
Copy link
Contributor Author

Closed in favor of native solution, see these two PR's:

Android Native solution: #1577
iOS native solution: #1597

@cameronvoell cameronvoell deleted the add/mobile-fullscreen-image-preview branch November 21, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile [Status] DO NOT MERGE Do not merge this PR [Status] Needs Design Review Needs design review or sign-off before shipping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant