Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/mobile fullscreen image preview #1484

Conversation

cameronvoell
Copy link
Contributor

Fixes #1286 *
gutenberg PR: WordPress/gutenberg#17109

*Image fullscreen functionality is behind DEV flag until we fix Android rotation issues, or limit this feature to iOS and enable an alternative fullscreen preview on Android.

To test:

  1. Open article in the block editor.
  2. Navigate to an image block with an image loaded, or add a new image block and add an image
  3. Select the image block and notice the blue border shows around the image
  4. Press the image while the image block is selected and notice the image will be viewed in fullscreen.
  5. Press outside the boundaries of the image in fullscreen mode, or swipe the image down to exit the fullscreen image preview.

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@cameronvoell cameronvoell added Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile and removed [Status] Not Ready For Review labels Oct 30, 2019
@cameronvoell cameronvoell reopened this Nov 1, 2019
@cameronvoell
Copy link
Contributor Author

Closed in favor of #1527

Now I have wp-mobile access, not using my fork is simpler for creating WP iOS and WP Android PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Fullscreen Preview to Image Options
1 participant