-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gallery Block #1498
Add Gallery Block #1498
Conversation
b14e498
to
873ac6f
Compare
# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg # src/initial-html.js
# Conflicts: # react-native-aztec/ios/Cartfile # react-native-aztec/ios/Cartfile.resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working pretty well 🎉 I think this is ready to go!
Tested both on WPiOS & WPAndroid using peril links to make sure I am seeing the release version.
Alternatively I also tested with metro on to be able to catch any potential validation errors&red screens.
Things I've tested:
- Verified that release version only has WP media library option
- Tile actions: move left/right, remove
- Column count setting works ok
- Slider works smoothly
- Crop image settings work ok
- Dark mode looks good on iOS
- Avoiding of adding multiple images works good
- VoiceOver works good on iOS
- Interaction with web works good
- Portrait landscape modes, with devices and iPad
- Tested on self-hosted site/premium/atomic
I just spotted one problem about link settings, this is only happening with my premium site, business site works all OK.
- Change link settings on web(should be a premium site)
- Open post on mobile
- It'll show this screen on mobile:
I think we can iterate on this. Since it is not reproducible on atomic sites, this looks similar to the problem we currently have on Video block where Jetpack changes the output html so maybe it won't have a solution on our side. I'll open an issue to make sure we can track.
Opened this issue to track that problem about links |
Description
This PR is a first iteration for a semi-cross-platform Gallery block. This adds the gallery block, which should allow viewing, editing, and creating gallery blocks within the editor. In this 1st iteration, upload options are disabled, and new images can only be added via the WordPress Media Library.
Related PRs
gutenberg: WordPress/gutenberg#18265
WordPress-Android: wordpress-mobile/WordPress-Android#10703
WordPress-iOS: wordpress-mobile/WordPress-iOS#12908
Tests
Loading
A post with a gallery block should load normally, and display the gallery block.
Steps:
Expected behavior:
Saving
A gallery created / edited in the mobile WordPress app should be openable on web.
Steps:
Expected behavior:
Adding images
You should be able to add images to a gallery from WordPress Media Library.
Note: Upload options should currently be disabled in production.
Steps:
Expected behavior:
Screencast
Moving images
It should be possible to re-order gallery images.
Steps:
Expected behavior:
Screencast
Removing images
It should be possible to remove images from the gallery.
Steps:
Expected behavior:
Screencast
Columns
The columns setting is used to control the number of columns in the gallery layout. The maximum value for this setting should be limited to 8, or the number of images in the gallery, whichever is smaller.
On mobile, since the viewport width is limited, we also limit displayed columns. The displayed columns maximum should be 2 for portrait mode, and 4 for landscape.
Steps:
Expected behavior:
Screencasts
Captions
It should be possible to add captions on each image in the gallery. Also, it should be possible to add a caption for the whole gallery block.
RichText
It should be possible to add styled text to gallery captions
Steps:
Expected behavior:
Screencast
Captions grow
Captions should grow to display larger captions
Steps:
Expected behavior:
Screencast
Scrollable captions
Large captions should be scrollable
Steps:
Expected behavior:
Screencast
Orientation change
The caption block should respond well to orientation changes. The displayed columns should adapt to respond to the new viewport width after the orientation change.
Steps:
Expected behavior:
Screencast
Crop images
The crop setting should allow you to turn cropping on or off.
Steps:
Expected behavior:
Screencast
Note:
Currently, iOS images are displayed with a lower resolution. There is ongoing work to address this in another PR: wordpress-mobile/WordPress-iOS#13042.
Update release notes:
RELEASE-NOTES.txt
.