Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block - semi cross platform approach #1416

Closed
3 tasks done
pinarol opened this issue Oct 7, 2019 · 2 comments
Closed
3 tasks done

Gallery block - semi cross platform approach #1416

pinarol opened this issue Oct 7, 2019 · 2 comments
Assignees

Comments

@pinarol
Copy link
Contributor

pinarol commented Oct 7, 2019

We can still have single edit.js and share @wordpress/components imports with web. But since we don't have an approved approach for replacing the web elements yet let's re-think about x-platform tiles, image subtasks. Especially if we think we won't be able to use the x-platform image component without the rest of the primitives let's re-think about the ideal next steps.

This issue is just for documenting the next steps, doesn't mean that we'll track the whole work with this, we should create new development subtasks if needed.

Some steps:

  • Make sure it works with existing content (i.e. open a post that was created on web)
  • Choosing media from WordPress Media Library
  • Choosing media from device (i.e. uploading media) tracked here: Mobile gallery block - Upload options #1610
@koke koke removed their assignment Oct 14, 2019
@mkevins
Copy link
Contributor

mkevins commented Nov 7, 2019

Description

This tracks the first iteration for a semi-cross-platform Gallery block. I have opened smaller PRs with smaller changesets to facilitate more focused discussion around the components used.

The gutenberg PRs for this feature have been rebased into a hierarchy described below. This "top level" PR can be used to test the aggregate changeset and integration of components within these related PRs.

Sibling PRs from other repositories

gutenberg-mobile: #1498
WordPress-Android: wordpress-mobile/WordPress-Android#10703
WordPress-iOS: wordpress-mobile/WordPress-iOS#12908

PR Hierarchy

@pinarol
Copy link
Contributor Author

pinarol commented Dec 9, 2019

I am closing this since upload is tracked here: #1610

@pinarol pinarol closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants