Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RNTAztec to iOS11 #1434

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Update RNTAztec to iOS11 #1434

merged 3 commits into from
Oct 11, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 11, 2019 •
edited
Loading

Fixes #1426 (comment)

To test:

  • Update WPiOS Gutenberg commit hash to the latest on this PR
  • Build and check that all pods builds properly.

Note: There might still be build errors due to wordpress-mobile/WordPress-iOS#12581 not yet being merged.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added [Type] Enhancement Improves a current area of the editor [Type] Technical Debt labels Oct 11, 2019
@etoledom etoledom added this to the 1.15 milestone Oct 11, 2019
@etoledom etoledom self-assigned this Oct 11, 2019
@etoledom etoledom mentioned this pull request Oct 11, 2019
Closed
koke
koke approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs perfectly. Thanks for fixing this 🙏

@koke koke merged commit 9c1cfb8 into develop Oct 11, 2019
@koke koke deleted the rntaztec-ios11 branch October 11, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koke koke koke approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees

@etoledom etoledom

Labels
[Type] Enhancement Improves a current area of the editor [Type] Technical Debt
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.
2 participants
@etoledom @koke