Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to iOS11 and Swift 5. #1426

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Conversation

SergioEstevao
Copy link
Contributor

This PR just updates the GB projects to have a minimum requirements of iOS 11 and to use Swift 5.

To test:

  • Check if project builds
  • Smoke test the demo app to see if all is correct.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added [Type] Enhancement Improves a current area of the editor [OS] iOS labels Oct 9, 2019
@SergioEstevao SergioEstevao added this to the 1.15 milestone Oct 9, 2019
@SergioEstevao SergioEstevao requested review from koke and etoledom October 9, 2019 12:43
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you 🙏

@SergioEstevao SergioEstevao merged commit 6523e9d into develop Oct 10, 2019
@SergioEstevao SergioEstevao deleted the issue/update_to_iOS11_Xcode11 branch October 10, 2019 08:37
@koke
Copy link
Member

koke commented Oct 10, 2019

This is being reverted in #1426. When I tried to update WPiOS to the new develop, I found two build issues.

The first is that this PR removed an #available(iOS 11.0, *) check in the aztec wrapper, but RNTAztecView.podspec still has a target of iOS 10. That one has an easy fix: just update s.platform on that podspec.

The second one, I got some errors building Gutenberg.framework about libxml2 not finding a header file. I investigated a bit but I couldn't make sense of the error:

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "libxml/HTMLparser.h"
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.1.sdk/usr/include/libxml2/libxml/HTMLparser.h:15:10: error: 'libxml/xmlversion.h' file not found
#include <libxml/xmlversion.h>
         ^
<unknown>:0: error: could not build Objective-C module 'libxml2'

@etoledom
Copy link
Contributor

I got some errors building Gutenberg.framework about libxml2 not finding a header file. I investigated a bit but I couldn't make sense of the error:

@koke - I think we should also bump the s.swift_version = '5.0' on RNAztec, that should fix the libxml2 error.

@etoledom etoledom mentioned this pull request Oct 11, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] iOS [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants