Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/562 add underline #1370

Merged
merged 14 commits into from
Oct 4, 2019
Merged

Issue/562 add underline #1370

merged 14 commits into from
Oct 4, 2019

Conversation

SergioEstevao
Copy link
Contributor

Fixes #562

Related GB PR: WordPress/gutenberg#17483

Simulator Screen Shot - iPhone Xʀ - 2019-09-19 at 14 43 18

To test:

  • Run the demo app
  • Check that the underline option shows when selecting text blocks: Paragraph/Heading/List
  • Use the format button and check that underline is set on content

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile label Sep 19, 2019
@SergioEstevao SergioEstevao added this to the Open Beta milestone Sep 19, 2019
@SergioEstevao SergioEstevao mentioned this pull request Sep 20, 2019
Closed
5 tasks
@SergioEstevao SergioEstevao requested review from daniloercoli and removed request for maxme September 20, 2019 10:22
@daniloercoli daniloercoli self-assigned this Sep 25, 2019
@daniloercoli
Copy link
Contributor

@SergioEstevao I've made some addition to this PR to make it working on Android.
Changes are in the Aztec wrapper for Android, were i enabled the CSS style plugin, and handled the new format-style sent by the JS side.

Would you mind to summon another dev to review both of the PRs. (This PR, and the other on the GB side, since i modified both of them).

@maxme
Copy link
Contributor

maxme commented Sep 25, 2019

Would you mind to summon another dev to review both of the PRs.

I'll have a look at that.

@maxme maxme self-requested a review September 25, 2019 09:46
maxme
maxme approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me, and works as expected. :shipit:

Side note (not related to the PR but related to the underlying code): I don't like the disableGBMode(false) function that does nothing. Ideally we would like a setGutenbergMode(true/false) that enable/disable plugins and set the right modes (calypso, focusable, etc.). It seems that disablePlugin() is not implemented in Aztec thus it's not that easy to refactor this now.

@etoledom etoledom modified the milestones: Open Beta, 1.15 Oct 2, 2019
@etoledom
Copy link
Contributor

etoledom commented Oct 2, 2019

Milestone moved to 1.15

@SergioEstevao SergioEstevao merged commit 00b7b05 into develop Oct 4, 2019
@SergioEstevao SergioEstevao deleted the issue/562_add_underline branch October 4, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxme maxme maxme approved these changes

@etoledom etoledom Awaiting requested review from etoledom

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

Assignees

@daniloercoli daniloercoli

@SergioEstevao SergioEstevao

Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

Add underline option for text-based blocks
4 participants
@SergioEstevao @daniloercoli @maxme @etoledom