-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/562 add underline #1370
Issue/562 add underline #1370
Conversation
# Conflicts: # gutenberg
… the JS side to Native when Underline is enabled on the current selection
@SergioEstevao I've made some addition to this PR to make it working on Android. Would you mind to summon another dev to review both of the PRs. (This PR, and the other on the GB side, since i modified both of them). |
I'll have a look at that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good to me, and works as expected.
Side note (not related to the PR but related to the underlying code): I don't like the disableGBMode(false)
function that does nothing. Ideally we would like a setGutenbergMode(true/false)
that enable/disable plugins and set the right modes (calypso, focusable, etc.). It seems that disablePlugin()
is not implemented in Aztec
thus it's not that easy to refactor this now.
Milestone moved to 1.15 |
# Conflicts: # gutenberg
Fixes #562
Related GB PR: WordPress/gutenberg#17483
To test:
Update release notes:
RELEASE-NOTES.txt
.