-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add underline option for text-based blocks #562
Comments
More on core's decision to not implement underline:
And extra discussion in https://core.trac.wordpress.org/ticket/27159 I have mixed feelings about the decision, but I don't think I can stand behind mobile diverging from core in something like this that it's hardly specific to mobile, so I'm closing this for now. |
I also have mixed feelings, but certainly understand the rationale. Closing for now sounds good to me. |
@koke I noticed that core re-added the underline style recently. Do we want to re-open this and consider adding it to mobile? |
Same. The rationale of not including it made sense, but perhaps market demand won out 😆 I think it's probably just an expected thing. |
Gutenberg on the web still seems to have it nowadays so, re-opening this ticket. |
Decision on which part to implement for this feature: WordPress/gutenberg#17483 (comment) |
We do still get requests for an underline option for text from apps users. I am not sure yet whether it would be helpful to create a new issue to track such requests, so I will leave the latest request here for now.
4-star review - Sep 18, 2020 at 11:28 PM - Galaxy On Nxt, WPAndroid 15.7-rc-3, Android 7.0 I saw in WordPress/gutenberg#17483 that we attempted to add an underline option in WPAndroid at one point but it was removed at the request of the core WordPress & Gutenberg developers. I think what has happened is that it has effectively been removed everywhere except on WordPress.com web. If we were to consider changing this again, or if we want to track requests for it, we might consider adding the option in the app for WordPress.com only which would create feature parity with both WordPress core and WordPress.com.
Either way is ok with me, and mainly I would like to know how you would like to receive feedback about this as we continue to receive user requests asking for an underline option through app reviews and elswhere. |
Just got feedback from 3736130-zen:
I couldn't find where else to report this for now (or if it's still needed to be reported). Happy to be redirected to the more appropriate place. |
Context
Core Gutenberg doesn't have an option for
underline
, but considering the usage data, there is some value in adding it to the style options alongside bold, italic, and strikethrough.In Aztec,
underline
is consistently in the top 10, and its usage is roughly double that ofstrikethrough
.Proposal
Add
underline
button to Quick Toolbar on text-based blocks such as Heading, Paragraph. I would add this right before thestrikethrough
option.Either of these icons could be used:
The text was updated successfully, but these errors were encountered: