Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/image size options #1350

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Sep 4, 2019

Fixes #1329

To test:

  1. Build Example app
  2. Click on an Image block (that already has an image)
  3. Press the gear button to bring up Image Options menu
  4. Verify new Size option exists, click size options
  5. Verify size options are shown and choose one.
  6. Re-open Image options menu and verify previously selected size is now shown as selected.

For verifying changes are correctly submitted to web backend:

  1. Run the metro bundler for this branch and build either Android or iOS WordPress app
  2. Use a wordpress.com account and navigate to a post, and begin editing in Gutenberg editor.
  3. Follow steps above to update Image Size options. Click Update.
  4. One the web, log in to the wordpress.com account, navigate to the article, and verify that the new Image size setting is shown.

Update release notes (hidden behind __DEV__ flag until networking for updating image urls is completed):

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Size options to Image Block
1 participant