Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Size options to Image Block #1329

Closed
cameronvoell opened this issue Aug 27, 2019 · 2 comments · Fixed by #1904
Closed

Add Size options to Image Block #1329

cameronvoell opened this issue Aug 27, 2019 · 2 comments · Fixed by #1904
Assignees
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile

Comments

@cameronvoell
Copy link
Contributor

See Parent issue #1263

The gutenberg-mobile editor should allow users to update Image Size options the same way that they can in the Aztec Editor.

Size options should be added to the existing image options BottomSheet menu. Selecting Size should lead to a second BottomSheet menu that lets the user change the size.

This first implementation will not alter the presentation of the Image in the editor based on its image size, as that feature is currently implemented in the Aztec Editor on iOS but not Android, so it is a slightly lower priority.

image

@hypest
Copy link
Contributor

hypest commented Sep 19, 2019

I haven't closely followed the conversation about the design side of the feature so, allow me to ask, what do you think about the nested bottomsheet here @iamthomasbishop?

@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented Sep 19, 2019

@hypest Nested sheets for settings – especially on iOS – would be huge. That was an original proposal but it's going to require some additional effort, so in the meantime we decided to open a second sheet where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aztec Parity Feature exists in Aztec but not yet in Gutenberg mobile
Projects
None yet
4 participants