Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Mocking changes for WordPress iOS UI and screenshot tests #3

Merged
merged 3 commits into from
Jun 10, 2019

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented May 27, 2019

This PR makes the necessary changes to the mocks definitions for compatibility with WordPress-iOS UI and screenshot tests (see wordpress-mobile/WordPress-iOS#11788).

WPiOS and WPAndroid differ in their network activity in several subtle ways. In some cases one uses a trailing slash where the other doesn't while in others they use different API endpoints or versions. This allows the mocks to work with both.

To Test

@jtreanor jtreanor changed the title Mocking changes for WordPress iOS UI tests Mocking changes for WordPress iOS UI and screenshot tests May 28, 2019
@jtreanor jtreanor marked this pull request as ready for review May 28, 2019 13:40
Copy link
Member

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well. 👍 I also took a quick look through the mocks and everything looks reasonable. :shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants