Update libs/mocks subtree with WPiOS updates #10040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: libs/mocks git-subtree-split: 03f0ad91646578e7ed0e20b2b1c0965c21152027
Generated by 🚫 dangerJS |
JavonDavis
reviewed
Jun 14, 2019
There was a problem hiding this comment.
@jtreanor The tests seem to be failing for me... The publish test fails with the following output
com.github.tomakehurst.wiremock.client.VerificationException: 12 requests were unmatched by any stub mapping. Shown with closest stub mappings:
expected:<
GET
/rest/v1.1/sites/158396482/media/?number=48&mime_type=image%2F&locale=en_US
Query: media_type = image
Query: number = 1
> but was:<
GET
/rest/v1.1/sites/158396482/media/?number=48&mime_type=image%2F&locale=en_US
number: 48
>
expected:<
GET
/rest/v1.1/sites/158396482/media/?number=48&mime_type=image%2F&locale=en_US
Query: number = 100
> but was:<
GET
/rest/v1.1/sites/158396482/media/?number=48&mime_type=image%2F&locale=en_US
number: 48
>
expected:<
GET
/rest/v1.1/sites/158396482/media/151/
> but was:<
GET
/rest/v1.1/sites/158396482/media/?number=48&mime_type=image%2F&locale=en_US
>
expected:<
GET
/rest/v1.1/sites/158396482/media/?number=48&locale=en_US
Query: media_type = image
Query: number = 1
> but was:<
GET
/rest/v1.1/sites/158396482/media/?number=48&locale=en_US
number: 48
>
expected:<
GET
/rest/v1.1/sites/158396482/media/?number=48&locale=en_US
Query: number = 100
> but was:<
GET
/rest/v1.1/sites/158396482/media/?number=48&locale=en_US
number: 48
>
expected:<
GET
/rest/v1.1/sites/158396482/media/151/
> but was:<
GET
/rest/v1.1/sites/158396482/media/?number=48&locale=en_US
>
expected:<
GET
/rest/v1.1/sites/158396482/media/151/
> but was:<
GET
/rest/v1.1/sites/158396482/media/62/?locale=en_US
>
expected:<
GET
/rest/v1.1/sites/158396482/tags
> but was:<
GET
/rest/v1.1/sites/158396482/media/62/?locale=en_US
>
expected:<
GET
/rest/v1.1/sites/158396482/settings
> but was:<
GET
/rest/v1.1/sites/158396482/media/62/?locale=en_US
>
expected:<
GET
/rest/v1.1/sites/158396482/media/151/
> but was:<
GET
/rest/v1.1/sites/158396482/media/62/?locale=en_US
>
expected:<
GET
/rest/v1.1/sites/158396482/tags
> but was:<
GET
/rest/v1.1/sites/158396482/media/62/?locale=en_US
>
expected:<
GET
/rest/v1.1/sites/158396482/settings
> but was:<
GET
/rest/v1.1/sites/158396482/media/62/?locale=en_US
>
at com.github.tomakehurst.wiremock.junit.WireMockRule.checkForUnmatchedRequests(WireMockRule.java:92)
at com.github.tomakehurst.wiremock.junit.WireMockRule.access$000(WireMockRule.java:34)
at com.github.tomakehurst.wiremock.junit.WireMockRule$1.evaluate(WireMockRule.java:74)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:388)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2145)
The magic link login also fails on this screen,
I'll continue looking at it but let me know if I'm missing something here
|
Thanks @JavonDavis! Those errors should have been fixed by 0c1ba96 🤔 If its still broken with the latest changes to the branch, let me know! |
JavonDavis
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that WPiOS uses the same mocks as in
libs/mocks(see wordpress-mobile/WordPress-iOS#11788), we can pull those changes back in here as a subtree.This is a very large diff but almost all of it has all been reviewed already. The vast majority of the changes are from wordpress-mobile/WordPressMocks#3.
The only unreviewed changed are in this commit: 0c1ba96
To test:
Update release notes:
RELEASE-NOTES.txt.