Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show meaningful error when xmlrpc broken #48

Merged
merged 7 commits into from
Oct 24, 2018

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Oct 23, 2018

Fixes WPiOS wordpress-mobile/WordPress-iOS#10293

This does two things:

  1. Updates the non-WP site message to match Android.
  2. Adds another validation error case that displays a message specifically for WP sites where XML-RPC is not set up correctly.

Can be fully tested on WPiOS PR wordpress-mobile/WordPress-iOS#10308.

Copy link
Member

@aerych aerych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @ScoutHarris ! Tested as described. Test sites were the sample customer site you gave me and google.com. Everything worked. :)
:shipit:

@ScoutHarris ScoutHarris merged commit cd55dfe into develop Oct 24, 2018
@ScoutHarris ScoutHarris deleted the fix/show_meaningful_error_when_xmlrpc_broken branch October 24, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants