Show meaningful error when xmlrpc broken #10308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerych
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Commented on wordpress-mobile/WordPressKit-iOS#48
with the updated pod :)
ScoutHarris
deleted the
fix/10293-show_meaningful_error_when_xmlrpc_broken
branch
jkmassel
pushed a commit
that referenced
this pull request
Oct 25, 2018
…gful_error_when_xmlrpc_broken Show meaningful error when xmlrpc broken
jtreanor
pushed a commit
that referenced
this pull request
Nov 20, 2018
…gful_error_when_xmlrpc_broken Show meaningful error when xmlrpc broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10293
NOTE: This uses an updated
WordPressKitpod. I will update thePodfileto a valid version after it's been approved.Related
WordPressKitPR: wordpress-mobile/WordPressKit-iOS#48To test:
Log in by entering your site address.Couldn't connect to the WordPress site. There is no valid WordPress site at this address. Check the site address (URL) you entered.Log in by entering your site address.Couldn't connect. Required XML-RPC methods are missing on the server.