Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical Comments: return total comment count #468

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Nov 19, 2021

Description

Ref: wordpress-mobile/WordPress-iOS#17511
WPiOS PR: wordpress-mobile/WordPress-iOS#17515

This updates the syncHierarchicalCommentsForPost method to return the total comment count provided by the API.

Testing Details

Can be tested with referenced WPiOS PR.

  • Please check here if your pull request includes additional test coverage.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ScoutHarris ScoutHarris merged commit 08a0d8f into develop Nov 22, 2021
@ScoutHarris ScoutHarris deleted the feature/17511-return_comments_count branch November 22, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants