Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical Comments: add fetch method to provide count #17515

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

ScoutHarris
Copy link
Contributor

Ref: #17511
WPKit PR: wordpress-mobile/WordPressKit-iOS#468

This change does two things:

  • Uses the WPKit changes to surface the totalComments count from the API.
  • Adds a new syncHierarchicalCommentsForPost method variant to specify the number of top level comments to fetch. The default is 20, but only 2 will be needed for the post details comments.

To test:

The totalCount and new method are not used yet, so just verify threaded comments are fetched as expected.

  • Go to Reader and select a post with comments.
  • Verify the comments shown are as expected.

Regression Notes

  1. Potential unintended areas of impact
    Comment fetching could be affected.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Verified comments are fetched as expected.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

… method variant to specify the number of comments to fetch.
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 20, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ScoutHarris
Copy link
Contributor Author

Thanks @dvdchr !

@ScoutHarris ScoutHarris merged commit d56a867 into develop Nov 22, 2021
@ScoutHarris ScoutHarris deleted the feature/17511-update_comment_fetching branch November 22, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants