Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt WordPressKit breaking changes #829

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Jan 24, 2024

This PR adopts a WordPressComRestApiError changes in the latest WordPressKit.


  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@crazytonyli crazytonyli requested review from mokagio and kean January 28, 2024 20:16
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

I stumbled upon these changes since I'm making some unrelated updates to WPKit.

I checked the main refactoring PR https://github.com/wordpress-mobile/WordPressKit-iOS/ as well.

@crazytonyli crazytonyli merged commit b9db2bb into trunk Jan 29, 2024
7 checks passed
@crazytonyli crazytonyli deleted the adopt-wordpresskit-changes branch January 29, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants