Update WordPressKit and WordPressAuthenticator #22434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22434-92427fe | |
| Version | 24.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 92427fe | |
| App Center Build | WPiOS - One-Offs #8586 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22434-92427fe | |
| Version | 24.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 92427fe | |
| App Center Build | jetpack-installable-builds #7615 |
2 tasks
crazytonyli
changed the title
|
Thanks, @crazytonyli ! Are there any specific test steps? I ran a smoke test and it LGTM. |
kean
approved these changes
Jan 29, 2024
kean
reviewed
Jan 29, 2024
Podfile
Outdated
| # pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', commit: '' | ||
| # pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', branch: 'trunk' | ||
| # pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', branch: 'wordpress-com-rest-api-error-refactor' |
There was a problem hiding this comment.
Please this line and line 144.
There was a problem hiding this comment.
Can you clarify what needs to be done regarding line 144? I'll merge this PR for now to unblock others. I'm happy to address any further issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest WordPressKit introduces a breaking change which requires code changes in the apps and WordPressAuthenticator.
This PR updates WordPressKit to the latest version and uses a WordPressAuthenticator commit (part of wordpress-mobile/WordPressAuthenticator-iOS#829) that adopts to the WordPressKit breaking changes. We can merge this PR after wordpress-mobile/WordPressAuthenticator-iOS#829 is merged.
Regression Notes
None
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A