Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WordPressAuthenticator.bundle public #78

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Conversation

jtreanor
Copy link
Contributor

This makes the bundle var in WordPressAuthenticator public so that the bundle can be accessed from outside the framework.

This will allow wordpress-mobile/WordPress-iOS#11444 to be fixed.

Copy link
Contributor

@astralbodies astralbodies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an elegant and simple solution! :shipit:

@jtreanor jtreanor merged commit 4e90dbb into develop Apr 11, 2019
@jtreanor jtreanor deleted the fix-bundle-loading branch April 11, 2019 13:56
@jtreanor
Copy link
Contributor Author

I'm going to cherry pick this into a 1.3.1 so only these changes are included in WPiOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants