Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading WordPressAuthenticator xibs #11453

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Conversation

jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Apr 11, 2019

Fixes #11444

It relies on the changes in wordpress-mobile/WordPressAuthenticator-iOS#78. That should be merged and released before this PR.

To test:

  1. Open the app logged out.
  2. Start the email signup flow.
  3. Enter a new email address and confirm the signup via the magic link.
  4. On the signup epilogue screen, tap the username field to try to change your username.
  5. It doesn't crash.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor force-pushed the fix-bundle-loading branch from 2eea297 to 8bb4ebb Compare April 11, 2019 14:09
@jtreanor
Copy link
Contributor Author

Thanks @astralbodies! It's now updated to use 1.3.1 of WordPressAuthenticator. There are no changes other than pointing to the actual release so I will merge when green.

@jtreanor jtreanor merged commit fd431ce into release/12.2 Apr 11, 2019
@jtreanor jtreanor deleted the fix-bundle-loading branch April 11, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants