Bump version to 4.1.1 #699
Conversation
There was a problem hiding this comment.
This is my first release after the
CHANGELOG.mdintroduction, so hopefully it's done correctly 🤞
LGTM! 👏 😄
Question: Does the
.xcversionfile need to be updated to 14.0 as well? I am guessing yes, but I am not familiar with the xcode version updates, so I'd appreciate some help.
This question comes at a very good time, as @AliSoftware suggested automation changes to fix an issue and overall improved the whole process in WooCommerce iOS.
If that's okay with you, I'll take this from here. I've suggested some minor changes in the Woo setup and I'd be happy to replicated the setup we'll land with from there in this repo (I'm also actively working on this repo, so it's no extra effort for me).
| ## 4.1.0-beta.1 [Unreleased] | ||
| ## 4.2.0 [Unreleased] |
There was a problem hiding this comment.
The following is out of scope from this PR, because it correctly update the code based on its existing state, and also a big nitpick.
IMHO, this header should always stay "Unreleased" because it's up to the release manager (eventually the automation) to parse what went into the changelog since the latest release and decide what number to use based on the kind of changes.
I appreciate the idea of suggesting a new version number but I feel it would be neater if the header for unreleased code stayed fixed.
I might open a PR later on to update the template to make this clearer and we can discuss then.
There was a problem hiding this comment.
Agreed. Predicted next version number will vary as new items will get added to the unreleased section, which is why we don't include a version number in it until we actually do the next release and decide on it based on content of the section and semver rules
This is my first release after the
CHANGELOG.mdintroduction, so hopefully it's done correctly 🤞Note that the initial commit failed with
VM xcode-13.4.1 is invalidso I updated the xcode image to 14 which is the image that is in use in WCiOS.Question: Does the
.xcversionfile need to be updated to14.0as well? I am guessing yes, but I am not familiar with the xcode version updates, so I'd appreciate some help.Update
I had a few CI failures during publishing of the
4.1.0version and ended up having to bump the version to4.1.1.