Bash cache & UIPasteBoard tests updates
#686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
force-pushed
the
mokagio/xcode-14
branch
2 times, most recently
from
8e024f5 to
dce86f2
Compare
See discussion at #696
This new version has an improved Ruby Bundler management.
mokagio
force-pushed
the
mokagio/xcode-14
branch
from
dce86f2 to
0bb055d
Compare
mokagio
changed the title
UIPasteBoard tests updates
AliSoftware
requested changes
Nov 7, 2022
Comment on lines
+17
to
+24
| // FIXME: We'll need to find a way to make the test work the new pasteboard rules | ||
| // | ||
| // See: | ||
| // - https://developer.apple.com/forums/thread/713770 | ||
| // - https://sarunw.com/posts/uipasteboard-privacy-change-ios16/ | ||
| // - https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/issues/696 | ||
| XCTExpectFailure("Paste board access has changed in iOS 16 and this test is now failing") | ||
|
|
There was a problem hiding this comment.
What if we happen to run the Unit Tests using an iPhone Simulator that runs iOS 15.4 or older? Shouldn't we guard this against the iOS runtime version?
Probably with something like this:
Suggested change
| // FIXME: We'll need to find a way to make the test work the new pasteboard rules | |
| // | |
| // See: | |
| // - https://developer.apple.com/forums/thread/713770 | |
| // - https://sarunw.com/posts/uipasteboard-privacy-change-ios16/ | |
| // - https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/issues/696 | |
| XCTExpectFailure("Paste board access has changed in iOS 16 and this test is now failing") | |
| // FIXME: We'll need to find a way to make the test work the new pasteboard rules | |
| // | |
| // See: | |
| // - https://developer.apple.com/forums/thread/713770 | |
| // - https://sarunw.com/posts/uipasteboard-privacy-change-ios16/ | |
| // - https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/issues/696 | |
| if ProcessInfo.processInfo.isOperatingSystemAtLeast(.init(majorVersion: 16, minorVersion: 0, patchVersion: 0)) { | |
| XCTExpectFailure("Pasteboard access has changed in iOS 16 and this test is now failing") | |
| } |
There was a problem hiding this comment.
Confirmed this is needed, by testing on an iOS 15.4 simulator 😉
There was a problem hiding this comment.
Neat technique.
But do we really need it? Yes, the tests will fail on iOS < 16, but how much of a concern is that for us? What are the chances we'll need to run the tests in iOS < 16?
Thinking about it, it might be beneficial if the UIPasteboard changes are such that we'll need different code between iOS < 16 and >= 16. 🤔 I haven't looked at that yet, this might be a good time to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as one to upgrade the project to build using the
xcode-14image in CI. However I didn't iterate on it fast enough and other PRs (#695, #699) did most of the work. So, this PR now only tracks minor improvements.