Expose view controller background colors for styling by host apps #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jleandroperez would you please review? this one is ready |
jleandroperez
requested changes
Aug 3, 2018
There was a problem hiding this comment.
@mindgraffiti Looks great!! Can we please please move the change to the shared base class?. THANK YOU!!!
| /// | ||
| @objc func styleBackground() { | ||
| view.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | ||
| } |
There was a problem hiding this comment.
Can we move this snippet to the base class?
| view.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | ||
| } | ||
|
|
||
|
|
| @objc func styleBackground() { | ||
| view.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | ||
| } | ||
|
|
| private func styleBackground() { | ||
| view.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | ||
| } | ||
|
|
| /// | ||
| private func styleBackground() { | ||
| view.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | ||
| } |
| @objc func styleBackground() { | ||
| view.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | ||
| } | ||
|
|
| @objc func styleBackground() { | ||
| view.backgroundColor = WordPressAuthenticator.shared.style.viewControllerBackgroundColor | ||
| } | ||
|
|
|
ready for another look. thank you @jleandroperez +1 |
jleandroperez
approved these changes
Aug 7, 2018
|
thank you Jorge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Every view controller in the authentication flow is set to
WPStyleGuide.lightGreyin InterfaceBuilder. Need to remove the manual background color assignment, expose the view controller background color property, and set it in both host apps.To test please see: woocommerce/woocommerce-ios#195