Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More WPAuth styling options #195

Merged
merged 7 commits into from
Aug 7, 2018
Merged

More WPAuth styling options #195

merged 7 commits into from
Aug 7, 2018

Conversation

mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Jul 27, 2018 •
edited by jleandroperez
Loading

In this PR, the WordPressAuthenticator-iOS framework now has new styling options exposed for use by the host apps, navBarImage, and viewControllerBackgroundColor.

Closes #146

  1. Check out this branch
  2. Log out of the app if you're logged in and log back in again
  3. Look for the center logo in the nav bar and the background colors

Before & After:

@mindgraffiti mindgraffiti added the type: enhancement A request for an enhancement. label Jul 27, 2018
@mindgraffiti mindgraffiti added this to the External closed beta milestone Jul 27, 2018
@mindgraffiti mindgraffiti self-assigned this Jul 27, 2018
@mindgraffiti mindgraffiti mentioned this pull request Jul 27, 2018
Merged
@jleandroperez
Copy link
Collaborator

Note: Updated the Issue Description so that this PR will close Issue #146.

@mindgraffiti please let us know whenever this one is ready for review, thank you!!!

@mindgraffiti
Copy link
Contributor Author

Merge conflicts fixed. Ready for review @jleandroperez 🔢

jleandroperez
jleandroperez approved these changes Aug 7, 2018
View reviewed changes
Copy link
Collaborator

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this patched up @mindgraffiti !!!

:shipit:

@mindgraffiti mindgraffiti merged commit 53025ea into develop Aug 7, 2018
@mindgraffiti
Copy link
Contributor Author

thanks for the review Jorge!

@mindgraffiti mindgraffiti deleted the feature/more-configurations branch August 7, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleandroperez jleandroperez jleandroperez approved these changes

Assignees

@mindgraffiti mindgraffiti

Labels
type: enhancement A request for an enhancement.
Projects
None yet
Milestone
External open beta
Development

Successfully merging this pull request may close these issues.
2 participants
@mindgraffiti @jleandroperez