Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUX buttons are truncated on smaller devices #155

Closed
frosty opened this issue Nov 12, 2019 · 3 comments · Fixed by #213, #452 or wordpress-mobile/WordPress-iOS#14874
Closed

NUX buttons are truncated on smaller devices #155

frosty opened this issue Nov 12, 2019 · 3 comments · Fixed by #213, #452 or wordpress-mobile/WordPress-iOS#14874
Labels
bug Something isn't working

Comments

@frosty
Copy link
Contributor

frosty commented Nov 12, 2019

I just launched the app on the iPhone SE simulator, and noticed that the "continue with..." buttons in the NUX are truncated on smaller devices.

Per pbArwn-5X-p2, scale the button text to fit the width instead of truncating.

I guess we'll need to either wrap the text or shrink it when this happens.

@frosty frosty added the bug Something isn't working label Nov 12, 2019
@mindgraffiti
Copy link
Contributor

mindgraffiti commented Feb 24, 2020

Related host app issue: wordpress-mobile/WordPress-iOS#13466.

@ScoutHarris
Copy link
Contributor

Reopening as this is no longer fixed with #213. For reference, the change that reverted the fix (in order to fix something else) was #216.

@mindgraffiti
Copy link
Contributor

Also related: NUXButton doesn't shrink back down to the correct size when Dynamic Text is applied (make it a much larger size), then re-applied (set it back to normal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants