Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GlobalStep] “Continue with WordPress.com” Log In option is unnecessarily cropped #13466

Closed
wptester9845 opened this issue Feb 14, 2020 · 5 comments

Comments

@wptester9845
Copy link

wptester9845 commented Feb 14, 2020

Description

After the user presses Log In, the option “Continue with WordPress.com” is cropped to “Continue with...ordPress.com” this crop is unnecessary and the ... takes about as much space as the replaced text W would.
This issue only happens on small devices but there is enough space for the whole message to fit its button.

Reproduction Rate

4/4 100%

Expected behavior

The message “Continue with WordPress.com” should be fully displayed.

Actual behavior

The message is cropped to “Continue with...ordPress.com”.

Steps to reproduce the behavior

  1. Install WordPress 14.2
  2. Press the Log In button.
Tested on the following

iPhone SE (12.0.1)
iPhone 5S (11.4)

Please see the attached screenshot for more information

Submitted by:

Luis Pimenta

@rachelmcr
Copy link
Member

It looks like there isn't quite enough room for the text with the button padding, but the string is shortened in a very unfortunate way (especially as a first impression). This could also be relevant for i18n, i.e. if other languages make this string too long even on larger devices.

@ScoutHarris
Copy link
Contributor

@rachelmcr we could probably address this in the Unified Auth project. Since @mattmiklic is still working on the designs, maybe a solution can be worked out.

(cc @mindgraffiti )

@mindgraffiti
Copy link
Contributor

Hey @ScoutHarris thanks for the ping! @rachelmcr it's added to our Unified Auth project.

@ScoutHarris
Copy link
Contributor

@ScoutHarris
Copy link
Contributor

I'm going to leave this closed as a dupe of wordpress-mobile/WordPressAuthenticator-iOS#155. But noting here that this is no longer fixed. wordpress-mobile/WordPressAuthenticator-iOS#155 has been reopened and will track the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants