Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordwrap NUX button #14874

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Wordwrap NUX button #14874

merged 3 commits into from
Sep 10, 2020

Conversation

mindgraffiti
Copy link
Contributor

Fixes: wordpress-mobile/WordPressAuthenticator-iOS#155
Auth PR: wordpress-mobile/WordPressAuthenticator-iOS#452

There is an issue where iOS 12.0+ users on smaller devices do not get proper font scaling. This is an iOS 12 issue that doesn't happen on iOS 13. Instead of attempting to force iOS 12 to use the correct font scaling, we're going to word-wrap the long text in the button so it can be successfully read by the user.

Note that the buttons in the prologue are different because the UL&S project had updated designs to work from.

Before After

To test

Use a small device or simulator on iOS 12, such as the iPhone SE or iPhone 5S.

  1. Log out if logged in
  2. Observe the prologue buttons

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 10, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 10, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this!!

Simulator Screen Shot - iPhone SE - 2020-09-10 at 10 13 14

@mindgraffiti mindgraffiti merged commit 28ec50d into develop Sep 10, 2020
@mindgraffiti mindgraffiti deleted the fix/nux-button branch September 10, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NUX buttons are truncated on smaller devices
2 participants