Bloganuary: Replace hyphen with dash in Bloganuary nudge text

[wargcm]

Ref: pcdRpT-4FE-p2#comment-7965

Description

Replaces the hyphen (-) with a dash (—) in the Bloganuary nudge text on the dashboard card. Matching Android's string change here: wordpress-mobile/WordPress-Android#19774

Screenshot

Testing

To test:

• Set device to English
• Launch Jetpack and login
• Navigate to the dashboard if necessary
• 🔎 Verify the Bloganuary nudge text on the dashboard card uses a dash (—) instead of a hyphen (-)

Regression Notes

1. Potential unintended areas of impact
   N/A

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   N/A

3. What automated tests I added (or what prevented me from doing so)
   N/A
   PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[peril-wordpress-mobile]

	Warnings
⚠️	Localizable.strings should only be updated on release branches because it is generated automatically.

Generated by 🚫 dangerJS

[wargcm]

Given the red background, it appears GitHub thinks this is a syntax error. The file compiles fine though, but I can change this to a single line if we'd like.

[wargcm]

Decided to just update it: 6155351.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22213-372a322
	Version	23.8.1
	Bundle ID	org.wordpress.alpha
	Commit	372a322
	App Center Build	WPiOS - One-Offs #8112

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22213-372a322
	Version	23.8.1
	Bundle ID	com.jetpack.alpha
	Commit	372a322
	App Center Build	jetpack-installable-builds #7132

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[mokagio]

Tested locally, works as expected.

@wargcm +1 for manually editing the .strings as the hotfix automation does not download new strings from GlotPress because GlotPress holds the source of truth for the next upcoming version and as such there might be strings that were in the version an hotfix targets that are no longer in GlotPress, or new strings that are downloaded but unused.

Worth noting that:

• Until the en.lproj change reaches trunk, the GlotPress entry will still hold the version with the hyphen
• Many of the translators opted to remove the hyphen in their locale in favor of comma or semicolon. I found this interesting. I noticed this when git grep "Bloguanary -" -- WordPress/Resources returned only a couple of additional entries from the en-* edited in the first version of this PR. I wonder if they picked up on the typo or simply felt their version better suited their locale 🤷‍♂️

One final note. I double checked that the dahs used here was the "em dash" not the "en dash". The syntactic difference matters.. 👌

Method used: Copied the character from the Merriam-Webster link above, and pasted it in the search window for this diff in Chrome, verified there were 5 matches, one per each of the files touched.

[mokagio]

Just waiting for green CI to before merging...