Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bloganuary] Replace hyphen with em dash in Bloganuary Nudge text #19774

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

thomashorta
Copy link
Contributor

@thomashorta thomashorta commented Dec 12, 2023

Use the appropriate character in the Bloganuary text for US English, it should be an em and not a hyphen. This should target a hotfix branch for the 23.8 release, likely release/23.8.1.


To Test:

Check that the Bloganuary card on My Site dashboard shows the correct character for US English.


Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • None
  3. What automated tests I added (or what prevented me from doing so)

    • None

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 12, 2023

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 12, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19774-4c2c9f0
Commit4c2c9f0
Direct Downloadwordpress-prototype-build-pr19774-4c2c9f0.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 12, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19774-4c2c9f0
Commit4c2c9f0
Direct Downloadjetpack-prototype-build-pr19774-4c2c9f0.apk
Note: Google Login is not supported on these builds.

@thomashorta thomashorta changed the base branch from trunk to release/23.8.1 December 12, 2023 21:06
@thomashorta thomashorta requested a review from a team as a code owner December 12, 2023 21:06
@thomashorta thomashorta removed the request for review from a team December 12, 2023 21:22
@thomashorta thomashorta force-pushed the hotfix/bloganuary-nudge-text-em-dash branch from 7db59d7 to 4c2c9f0 Compare December 12, 2023 21:23
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@thomashorta thomashorta merged commit 4df7f46 into release/23.8.1 Dec 12, 2023
20 checks passed
@thomashorta thomashorta deleted the hotfix/bloganuary-nudge-text-em-dash branch December 12, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants