-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bloganuary] Replace hyphen with em dash in Bloganuary Nudge text #19774
Merged
thomashorta
merged 1 commit into
release/23.8.1
from
hotfix/bloganuary-nudge-text-em-dash
Dec 12, 2023
Merged
[Bloganuary] Replace hyphen with em dash in Bloganuary Nudge text #19774
thomashorta
merged 1 commit into
release/23.8.1
from
hotfix/bloganuary-nudge-text-em-dash
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
thomashorta
force-pushed
the
hotfix/bloganuary-nudge-text-em-dash
branch
from
December 12, 2023 21:23
7db59d7
to
4c2c9f0
Compare
Generated by 🚫 Danger |
RenanLukas
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
13 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the appropriate character in the Bloganuary text for US English, it should be an
em
and not ahyphen
. This should target a hotfix branch for the 23.8 release, likelyrelease/23.8.1
.To Test:
Check that the Bloganuary card on My Site dashboard shows the correct character for US English.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.