Posts & Pages: Add tags sync

WordPress/Classes/ViewRelated/Post/AbstractPostListViewController.swift

@@ -7,7 +7,6 @@ import WordPressFlux
 
 class AbstractPostListViewController: UIViewController,
                                       WPContentSyncHelperDelegate,
-                                      UISearchControllerDelegate,
                                       WPTableViewHandlerDelegate,
                                       NetworkAwareUI // This protocol is not in an extension so that subclasses can override noConnectionMessage()
 {
@@ -201,14 +200,10 @@ class AbstractPostListViewController: UIViewController,
     }
 
     private func configureSearchController() {
-        searchController.delegate = self
-        searchController.searchResultsUpdater = searchResultsViewController
-        searchController.showsSearchResultsController = true
-        searchResultsViewController.searchController = searchController
+        searchResultsViewController.configure(searchController)
         searchResultsViewController.listViewController = self
 
         definesPresentationContext = true
-
         navigationItem.searchController = searchController
     }
 
@@ -851,12 +846,6 @@ class AbstractPostListViewController: UIViewController,
         WPAnalytics.track(.postListStatusFilterChanged, withProperties: propertiesForAnalytics())
     }
 
-    // MARK: - UISearchControllerDelegate
-
-    func willPresentSearchController(_ searchController: UISearchController) {
-        WPAnalytics.track(.postListSearchOpened, withProperties: propertiesForAnalytics())
-    }
-
     // MARK: - NetworkAwareUI
 
     func contentIsEmpty() -> Bool {

WordPress/Classes/ViewRelated/Post/Search/PostSearchTokenTableCell.swift

@@ -6,7 +6,7 @@ final class PostSearchTokenTableCell: UITableViewCell {
     private lazy var stackView = UIStackView(arrangedSubviews: [
         iconView, titleLabel, UIView()
     ])
-    let separator = UIView()
+    private let separator = UIView()
 
     override init(style: UITableViewCell.CellStyle, reuseIdentifier: String?) {
         super.init(style: style, reuseIdentifier: reuseIdentifier)
@@ -18,7 +18,7 @@ final class PostSearchTokenTableCell: UITableViewCell {
         stackView.spacing = 8
         stackView.alignment = .center
         stackView.isLayoutMarginsRelativeArrangement = true
-        stackView.layoutMargins = UIEdgeInsets(top: 8, left: 16, bottom: 8, right: 16)
+        stackView.layoutMargins = UIEdgeInsets(top: 4, left: 16, bottom: 14, right: 16)
         stackView.translatesAutoresizingMaskIntoConstraints = false
 
         contentView.addSubview(stackView)
@@ -42,7 +42,10 @@ final class PostSearchTokenTableCell: UITableViewCell {
     func configure(with token: any PostSearchToken, isLast: Bool) {
         iconView.image = token.icon
         titleLabel.text = token.value
-        stackView.layoutMargins.bottom = isLast ? 14 : 8
+        configure(isLast: isLast)
+    }
+
+    func configure(isLast: Bool) {
         separator.isHidden = !isLast
     }
 }

WordPress/Classes/ViewRelated/Post/Search/PostSearchViewController.swift

@@ -1,7 +1,7 @@
 import UIKit
 import Combine
 
-final class PostSearchViewController: UIViewController, UITableViewDelegate, UISearchResultsUpdating {
+final class PostSearchViewController: UIViewController, UITableViewDelegate, UISearchControllerDelegate, UISearchResultsUpdating {
     weak var searchController: UISearchController?
     weak var listViewController: AbstractPostListViewController?
 
@@ -28,6 +28,14 @@ final class PostSearchViewController: UIViewController, UITableViewDelegate, UIS
         fatalError("init(coder:) has not been implemented")
     }
 
+    func configure(_ searchController: UISearchController) {
+        searchController.delegate = self
+        searchController.searchResultsUpdater = self
+        searchController.showsSearchResultsController = true
+
+        self.searchController = searchController
+    }
+
     override func viewDidLoad() {
         super.viewDidLoad()
 
@@ -120,7 +128,7 @@ final class PostSearchViewController: UIViewController, UITableViewDelegate, UIS
         for indexPath in tableView.indexPathsForVisibleRows ?? [] {
             if let cell = tableView.cellForRow(at: indexPath) as? PostSearchTokenTableCell {
                 let isLast = indexPath.row == viewModel.suggestedTokens.count - 1
-                cell.separator.isHidden = !isLast
+                cell.configure(isLast: isLast)
             }
         }
     }
@@ -175,6 +183,12 @@ final class PostSearchViewController: UIViewController, UITableViewDelegate, UIS
         }
     }
 
+    // MARK: - UISearchControllerDelegate
+
+    func willPresentSearchController(_ searchController: UISearchController) {
+        viewModel.willStartSearching()
+    }
+
     // MARK: - UISearchResultsUpdating
 
     func updateSearchResults(for searchController: UISearchController) {

WordPress/Classes/ViewRelated/Post/Search/PostSearchViewModel.swift

@@ -141,6 +141,12 @@ final class PostSearchViewModel: NSObject, PostSearchServiceDelegate {
         reload()
     }
 
+    func willStartSearching() {
+        WPAnalytics.track(.postListSearchOpened, withProperties: propertiesForAnalytics())
+
+        syncTags()
+    }
+
     // MARK: - Search (Remote)
 
     private func performRemoteSearch() {
@@ -223,4 +229,20 @@ final class PostSearchViewModel: NSObject, PostSearchServiceDelegate {
             self.reload()
         }
     }
+
+    // MARK: - Misc
+
+    private func syncTags() {
+        let tagsService = PostTagService(managedObjectContext: coreData.mainContext)
+        tagsService.syncTags(for: blog, success: { _ in }, failure: { _ in })
+    }
+
+    private func propertiesForAnalytics() -> [String: AnyObject] {
+        var properties = [String: AnyObject]()
+        properties["type"] = settings.postType.rawValue as AnyObject?
+        if let dotComID = blog.dotComID {
+            properties[WPAppAnalyticsKeyBlogID] = dotComID
+        }
+        return properties
+    }
 }