-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts & Pages: Add tags sync #21918
Merged
kean
merged 3 commits into
task/ui-modernization-posts-and-pages
from
task/fix-tags-not-loading
Oct 31, 2023
Merged
Posts & Pages: Add tags sync #21918
kean
merged 3 commits into
task/ui-modernization-posts-and-pages
from
task/fix-tags-not-loading
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
commented
Oct 30, 2023
@@ -851,12 +846,6 @@ class AbstractPostListViewController: UIViewController, | |||
WPAnalytics.track(.postListStatusFilterChanged, withProperties: propertiesForAnalytics()) | |||
} | |||
|
|||
// MARK: - UISearchControllerDelegate | |||
|
|||
func willPresentSearchController(_ searchController: UISearchController) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it to offload some a bit of code from this vc
kean
force-pushed
the
task/fix-tags-not-loading
branch
from
October 30, 2023 23:19
ea07ed7
to
73cd747
Compare
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
momo-ozawa
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21900
To test:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: