Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts & Pages: Add tags sync #21918

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Oct 30, 2023

Part of #21900

  • Fix an issue with tags not loaded on fresh launch
  • Fix layout issue with tokens (it was updating the constraints without reloading the cells)

To test:

  • Fresh install
  • Go to Posts / Search
  • Verify that tag suggestions work

Regression Notes

  1. Potential unintended areas of impact: Posts & Pages search
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean requested a review from momo-ozawa October 30, 2023 23:18
@kean kean marked this pull request as ready for review October 30, 2023 23:18
@@ -851,12 +846,6 @@ class AbstractPostListViewController: UIViewController,
WPAnalytics.track(.postListStatusFilterChanged, withProperties: propertiesForAnalytics())
}

// MARK: - UISearchControllerDelegate

func willPresentSearchController(_ searchController: UISearchController) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to offload some a bit of code from this vc

@kean kean force-pushed the task/fix-tags-not-loading branch from ea07ed7 to 73cd747 Compare October 30, 2023 23:19
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21918-73cd747
Version23.5
Bundle IDorg.wordpress.alpha
Commit73cd747
App Center BuildWPiOS - One-Offs #7603
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21918-73cd747
Version23.5
Bundle IDcom.jetpack.alpha
Commit73cd747
App Center Buildjetpack-installable-builds #6624
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit 89936d4 into task/ui-modernization-posts-and-pages Oct 31, 2023
@kean kean deleted the task/fix-tags-not-loading branch October 31, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants