Remove .nativePhotoPicker feature flag

[kean]

Remove .nativePhotoPicker feature flag and the associated code.

To test:

Requires smoke tests. Please, follow the main steps from the following PRs:

• Integrate PHPickerViewController in Featured Image flow #21391
• Integrate PHPickerViewController in Gravatar flow #21388
• Integrate PHPickerViewController in Site Icon picker #21370
• Integrate PHPickerViewController in Page Editor #21360

Regression Notes

1. Potential unintended areas of impact: Media Picker
2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[peril-wordpress-mobile]

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21681-b5a1209
	Version	23.4
	Bundle ID	org.wordpress.alpha
	Commit	b5a1209
	App Center Build	WPiOS - One-Offs #7376

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21681-b5a1209
	Version	23.4
	Bundle ID	com.jetpack.alpha
	Commit	b5a1209
	App Center Build	jetpack-installable-builds #6410

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[momo-ozawa]

Hey @kean, when I try to update my site icon, some times it doesn't update to the new photo. You see the spinner over the old icon, then the spinner goes away. If you pull to refresh, it shows the new photo.

I'm not sure if the device version matters here - I can reproduce this pretty consistently on my iPhone 14 Pro on iOS 16.6.1. I can't seem to reproduce this on the simulator (iPhone 15 Pro, iOS 17)

[kean]

@momo-ozawa , I opened a bug #21735. It doesn't seem to be related to the changes from this PR.

[momo-ozawa]

LGTM! Can you add release notes for this? Thanks! 🙇‍♀️

[kean]

Can you add release notes for this? Thanks! 🙇‍♀️

Done, thank you.