Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate PHPickerViewController in Gravatar flow #21388

Merged
merged 4 commits into from
Aug 23, 2023

Conversation

kean
Copy link
Contributor

@kean kean commented Aug 22, 2023

Part of #21190.

  • Update the Gravatar flows to use PHPickerViewController
  • Adds support for WebP (the existing solution doesn’t support it)

Tests

Important

  • Enable the "Native Photo Picker" feature flag before testing

Update Gravatar (Profile)

  • Open "My Profile"
  • Tap “Take Photo”
  • Verify that the front facing camera opens by default
  • Take a photo and verify that crop screen opens
  • Crop and use the photo; verify that it gets uploaded

Verify that the "Choose from Device" flow also works

Creating new Account

  • Create a new account with email
  • Verify the same "Update Gravatar" steps from the first test

This is the screen/flow you are looking for:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-22.at.10.35.01.mp4

Regression Notes

  1. Potential unintended areas of impact: Gravatar update flow
  2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
  3. What automated tests I added (or what prevented me from doing so): h/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@@ -1,11 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="13771" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removing the IB actions so that I could set them programatically.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 22, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21388-3f4c73d
Version23.0
Bundle IDorg.wordpress.alpha
Commit3f4c73d
App Center BuildWPiOS - One-Offs #6816
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Aug 22, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21388-3f4c73d
Version23.0
Bundle IDcom.jetpack.alpha
Commit3f4c73d
App Center Buildjetpack-installable-builds #5857
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, tested webp as well

@kean kean force-pushed the task/integrate-phpicker-avatar-flow branch from 0b83b4b to 3f4c73d Compare August 23, 2023 12:19
@kean kean enabled auto-merge August 23, 2023 12:19
@kean kean merged commit 411f316 into trunk Aug 23, 2023
@kean kean deleted the task/integrate-phpicker-avatar-flow branch August 23, 2023 12:50
@kean kean mentioned this pull request Oct 4, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants