Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service PR to diff 21.4.1 against 21.4 #19905

Closed
wants to merge 5 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 13, 2023

This is a PR to compare the changes that went into release/21.4.1 against its source, 21.4. In fact, the base branch service-branch/21.4 should be deleted as soon as we establish release/21.4.1 is okay.

I decided to create a PR instead of referring folks to GitHub's /compare page so that we can leave comments if there's something odd.

@twstokes @fluiddot this gives us the chance to double check all translations are in place as expected.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19905-91ac494 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19905-91ac494 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@fluiddot
Copy link
Contributor

@twstokes @fluiddot this gives us the chance to double check all translations are in place as expected.

I've taken a quick look at the translation files and seems that the missing strings referenced by @tiagomar in pcdRpT-1sp-p2#comment-2721 are now present. I haven't tested the builds and not sure if I'll have bandwidth today for this. @twstokes @tiagomar would you mind double-checking this too? Thanks!

@twstokes
Copy link
Contributor

@twstokes @fluiddot this gives us the chance to double check all translations are in place as expected.

I've taken a quick look at the translation files and seems that the missing strings referenced by @tiagomar in pcdRpT-1sp-p2#comment-2721 are now present. I haven't tested the builds and not sure if I'll have bandwidth today for this. @twstokes @tiagomar would you mind double-checking this too? Thanks!

Thanks @mokagio and @fluiddot! I spot-checked French and Arabic and it looks right to me:

Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 04 47 Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 05 01 Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 05 07 Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 05 29
Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 11 53 Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 12 01 Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 12 10 Simulator Screen Shot - iPhone 14 - 2023-01-13 at 22 12 20

@mokagio
Copy link
Contributor Author

mokagio commented Jan 16, 2023

🎉

Closing as no longer needed.

@mokagio mokagio closed this Jan 16, 2023
@mokagio mokagio deleted the release/21.4.1 branch February 6, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants