-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service PR to diff 21.4.1 against 21.4 #19905
Conversation
The fix was in the previous commit, 0fdcefc Interesting to note that the modified string was not the only one to change once the automate process run.
You can test the changes in WordPress from this Pull Request by:
|
You can test the changes in Jetpack from this Pull Request by:
|
I've taken a quick look at the translation files and seems that the missing strings referenced by @tiagomar in pcdRpT-1sp-p2#comment-2721 are now present. I haven't tested the builds and not sure if I'll have bandwidth today for this. @twstokes @tiagomar would you mind double-checking this too? Thanks! |
Thanks @mokagio and @fluiddot! I spot-checked French and Arabic and it looks right to me: |
🎉 Closing as no longer needed. |
This is a PR to compare the changes that went into
release/21.4.1
against its source,21.4
. In fact, the base branchservice-branch/21.4
should be deleted as soon as we establishrelease/21.4.1
is okay.I decided to create a PR instead of referring folks to GitHub's
/compare
page so that we can leave comments if there's something odd.@twstokes @fluiddot this gives us the chance to double check all translations are in place as expected.