Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content Migration Flow] Fix typo in notifications prompt #19878

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

twstokes
Copy link
Contributor

@twstokes twstokes commented Jan 9, 2023

Fixes #19871

Note: This was cut from the 21.4 tag in case we want to include it on upcoming hotfixes.

Testing

Follow steps outlined in the issue: #19871

Regression Notes

  1. Potential unintended areas of impact
  • None
  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  • None
  1. What automated tests I added (or what prevented me from doing so)
  • None

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@twstokes
Copy link
Contributor Author

twstokes commented Jan 9, 2023

@salimbraksa I'm not sure if this will be included in the hotfix yet, so I'll keep it as a draft for now. If you wouldn't mind reviewing I'd appreciate it. 🙇

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19878-f3b9ac2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19878-f3b9ac2 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@salimbraksa salimbraksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twstokes Thanks for fixing this typo. LGTM! 🚀

@mokagio mokagio changed the base branch from trunk to release/21.4.1 January 10, 2023 01:49
@twstokes twstokes marked this pull request as ready for review January 10, 2023 01:58
@mokagio mokagio merged commit 0fdcefc into release/21.4.1 Jan 10, 2023
@mokagio mokagio deleted the bug/notifications-typo branch January 10, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack migration: Spelling issue on notifications screen
4 participants