Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing photo permission message in image block #19577

Closed
wants to merge 2 commits into from
Closed

Fix missing photo permission message in image block #19577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
def07b6
Fix missing photo permission msg in image block
guarani Nov 10, 2022
5587e49
Added release note
guarani Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
21.2
-----
* [*] [internal] Refactored fetching posts in the Reader tab. [#19539]
* [*] [Block Editor] Fixed image block issue where no message was shown when permission to the device photos was not granted [#19577]


21.1
Expand Down
6 changes: 0 additions & 6 deletions WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaPickerHelper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ extension GutenbergMediaPickerHelper: WPMediaPickerViewControllerDelegate {
}
}

open func mediaPickerController(_ picker: WPMediaPickerViewController, handleError error: Error) -> Bool {
let alert = WPMediaPickerAlertHelper.buildAlertControllerWithError(error)
context.present(alert, animated: true)
return true
}

func mediaPickerControllerDidCancel(_ picker: WPMediaPickerViewController) {
mediaLibraryDataSource.searchCancelled()
context.dismiss(animated: true, completion: { self.invokeMediaPickerCallback(asset: nil) })
Expand Down