Fix missing photo permission message in image block

[guarani]

Fixes #19576

MediaPicker-iOS handles the display of a message when the app lacks photo permission. By implementing a delegate method, the app was overriding this and presenting the prompt from the block editor screen which is hidden behind the media picker screen, leading to this error:

2022-11-10 00:01:35.281384-0700 Jetpack[7225:42366] [Presentation] Attempt to present <UIAlertController: 0x7fa85aa9d200> on <WordPress.AztecNavigationController: 0x7fa849195400> (from <WordPress.GutenbergViewController: 0x7fa849030800>) whose view is not in the window hierarchy.

To fix this, I removed the delegate method. This means that the media picker doesn't try to call the delegate method (see code and instead calls wpm_showAlertWithError, which in turn shows the same permission alert that's shown when adding media via My Site → Menu → Media (which presents the alert on the media picker view controller, which is on-screen).

To test:

1. Ensure the app does not have access to photos:
   a. Go My Site tab → Menu → Media
   b. Go to add media, but deny the app permission
2. Now open a new post
3. Add the image block
4. Tap "Choose from device"
5. Notice the app now shows an alert prompting users to enable the missing permission

Regression Notes

1. Potential unintended areas of impact

Image block error handling could be inadvertently affected by this change.

2. What I did to test those areas of impact (or what existing automated tests I relied on)

I tested adding images via the image block both with and without the photo permission.

3. What automated tests I added (or what prevented me from doing so)

There were no existing tests I could easily build upon.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[guarani]

Hi @fluiddot, I wasn't sure who to add here as a reviewer.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19577-5587e49 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19577-5587e49 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[peril-wordpress-mobile]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[guarani]

@fluiddot, I noticed this change causes #18139 to regress, so I converted this back to a draft and removed you as reviewer. Sorry for the noise.

[mokagio]

Moving this to the 21.6 milestone as I'm running the 21.5 code freeze today and this is in draft state.

[kean]

I'm going to close it because it's not obsolete thanks to the changes made in #21190

[guarani]

Thanks for closing this, @kean!