-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stories: Upgrade Kanvas version #18967
Conversation
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
@@ -9,7 +9,7 @@ struct SiteIconPickerView: View { | |||
var onDismiss: (() -> Void)? = nil | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI - the Site Icon Picker is not currently in production, so these low-risk changes won't affect anything.
👋 @SiobhyB! I'm awaiting reviews on the Kanvas side, but I thought I'd add you as a reviewer in case you wanted to look at things ahead of time. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @twstokes 🙇♀️
I went through the testing steps you outlined, the story block test cases, and tried to break things through random steps. All looks good to me, with the original bugs squashed!
I know you're still waiting on an approval for tumblr/kanvas-ios#140, but wanted to share my testing so far and clear the way for you for when that PR gets approved. If changes are needed, feel welcome to re-request a review :D
Description
This PR upgrades Kanvas to version
1.4.3
which fixes a couple issues:Testing
App doesn't crash with many images
Text layers aren't lost if publishing is cancelled
Known issue
No output is shown after cancelling the publishing process and trying to add a photo from the camera.
A Github issue will be added if it doesn't already exist.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.