Reduce renderer memory consumption when exporting #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twstokes
changed the title
twstokes
added
stories
4 tasks
|
@afterxleep, @bjtitus - would you mind giving this a look? 🙇 Hopefully this change is straightforward - it seems like if there's no delegate to display a renderer's output we shouldn't bother with the output method. Yet, I do see where it's mutating A WPiOS build that includes these changes is here, but I could use your guidance if we need to test Tumblr. Thank you. |
twstokes
force-pushed
the
fix/multi-export-crash
branch
from
4d715e0 to
dd7b104
Compare
MultiEditorViewController: Reload the current editor during export process
twstokes
commented
Jul 6, 2022
| } | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
These changes are from #141.
bjtitus
approved these changes
Jul 6, 2022
Thank you for the review @bjtitus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Memory consumption grows constantly when exporting multiple images due to calls to
outputin the renderer. In instances where there's no delegate to process the renderer's pixel buffer, we can avoid running the function altogether.This will help alleviate WPiOS out-of-memory crashes: