Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: Fix detailed notification view not scrolling in landscape #18823

Merged
merged 4 commits into from
Jun 11, 2022

Conversation

hassaanelgarem
Copy link
Contributor

Fixes #18811

Description

Fixes an issue where the detailed notification view was not scrollable in landscape mode.

Testing Instructions

  1. Complete a Next Steps tour and get a notification
  2. Change phone to landscape mode
  3. Open navigations tab
  4. Click on the notification
  5. Make sure that the view is scrollable

Regression Notes

  1. Potential unintended areas of impact
    N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A
  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added this to the 20.1 milestone Jun 3, 2022
@hassaanelgarem hassaanelgarem self-assigned this Jun 3, 2022
@hassaanelgarem hassaanelgarem changed the title Notifications: Fix singel notification view not scrolling in landscape Notifications: Fix single notification view not scrolling in landscape Jun 3, 2022
@hassaanelgarem hassaanelgarem changed the title Notifications: Fix single notification view not scrolling in landscape Notifications: Fix detailed notification view not scrolling in landscape Jun 3, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 3, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18823-8c8eba3 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 3, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18823-8c8eba3 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@leandroalonso leandroalonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@hassaanelgarem hassaanelgarem enabled auto-merge June 11, 2022 00:01
@hassaanelgarem hassaanelgarem merged commit 38e5d4e into trunk Jun 11, 2022
@hassaanelgarem hassaanelgarem deleted the issue/18811-notifications-scroll-landscape-2 branch June 11, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notification] - Can't scroll notification when on landscape mode
3 participants