Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text flipping in rtl languages #18567

Merged
merged 2 commits into from
May 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* [*] Site Settings: we fixed an issue that prevented the site title to be updated when it changed in Site Settings [#18543]
* [*] Media Picker: Fixed an issue where the empty state view was being displayed incorrectly. [#18471]
* [*] Site Creation: we fixed an issue where the navigation buttons were not scaling when large fonts were selected on the device [#18559]
* [*] Widgets: we fixed an issue where text appeared flipped in rtl languages [#18567]

19.8
-----
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ struct FlexibleCard: View {
Spacer()
titleView
}
.flipsForRightToLeftLayoutDirection(true)
}
}
}
Expand Down
1 change: 0 additions & 1 deletion WordPress/WordPressStatsWidgets/Views/Cards/ListRow.swift
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ struct ListRow: View {
.frame(height: rowHeight)
.offset(x: 0, y: Constants.verticalCenteringOffset) // each row isn't _quite_ centered vertically
// and we're not entirely sure why yet, but this fixes it
.flipsForRightToLeftLayoutDirection(true)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ struct VerticalCard: View {
.accessibility(label: accessibilityLabel)

}
.flipsForRightToLeftLayoutDirection(true)
}
}

Expand Down
1 change: 0 additions & 1 deletion WordPress/WordPressStatsWidgets/Views/SingleStatView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ struct SingleStatView: View {
}
Spacer()
}
.flipsForRightToLeftLayoutDirection(true)
}
}