Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text flipping in rtl languages #18567

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

Gio2018
Copy link
Contributor

@Gio2018 Gio2018 commented May 11, 2022

Fixes #17731

This PR fixes an issue where text appeared flipped in rtl languages.

before after

To test:

  • checkout/build/run trunk (or any other branch different than this one)
  • Set the device language to an rtl language
  • Install some widgets
  • verify that text appears flipped: numbers and site names are easy to spot, but you can also look at the translations inside the Localizable.strings file of the language of your choice
  • checkout/build/run this branch
  • verify that text is not flipped anymore in the widgets

see above screenshots for more details.

Regression Notes

  1. Potential unintended areas of impact
    None. this PR only affects text in Widgets, for rtl languages

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested widgets in a rtl language

  3. What automated tests I added (or what prevented me from doing so)
    none
    PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Gio2018 Gio2018 added this to the 19.9 milestone May 11, 2022
@Gio2018 Gio2018 self-assigned this May 11, 2022
@Gio2018 Gio2018 requested review from ScoutHarris and frosty May 11, 2022 16:34
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18567-b4d2623 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18567-b4d2623 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gio2018 . LGTM. It looks like all the widgets now have the text in the correct order.

:shipit:

@Gio2018
Copy link
Contributor Author

Gio2018 commented May 11, 2022

Thanks for reviewing @ScoutHarris ! Yeah it seems that they finally got it 😄

@Gio2018 Gio2018 merged commit 2aee64b into trunk May 11, 2022
@Gio2018 Gio2018 deleted the issue/17731-widgets-mirroring-rtl branch May 11, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widget showing mirrored when RTL language is set
3 participants